Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/11157#discussion_r69635219
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -423,18 +432,35 @@ private[spark] class
MesosCoarseGrainedSchedulerBackend(
tasks.toMap
}
+ private def getResources(resources: JList[Resource], taskCPUs: Int,
taskMemory: Int)
+ : (List[Resource], List[List[Resource]], List[Long]) = {
+ val (afterCPUResources, cpuResourcesToUse) =
+ partitionResources(resources, "cpus", taskCPUs)
+ val (afterMemResources, memResourcesToUse) =
+ partitionResources(afterCPUResources.asJava, "mem", taskMemory)
--- End diff --
I just thought a newline separating the port handling would improve
readability. I generally prefer to separate each logical block with newlines.
Not a blocker.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
