Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14004 Hi, @cloud-fan . I've updated the PR. The following is a summary of changes. - To support `sentence('', null, null)`, `Sentences` extends `Expression` instead of `TerneryExpression`. - `getLocale` is merged into `getSentences`. (according to the comment.) - `getSentences` is now in `Sentences` expression. (Yep. I know. It's accidentaly due to my misunderstanding) - Add more testcases and move test location into `StringExpressionsSuite` and `StringFunctionsSuite`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org