Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13990#discussion_r69776800
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
 ---
    @@ -393,3 +393,80 @@ case class CreateNamedStructUnsafe(children: 
Seq[Expression]) extends Expression
     
       override def prettyName: String = "named_struct_unsafe"
     }
    +
    +/**
    + * Creates a map after splitting the input text into key/value pairs using 
delimeters
    + */
    +@ExpressionDescription(
    +  usage = """_FUNC_(text[, pairDelim, keyValueDelim]) - Creates a map 
after splitting the text into
    +    key/value pairs using delimiters.
    +    Default delimiters are ',' for pairDelim and ':' for keyValueDelim.""",
    +  extended = """ > SELECT _FUNC_('a:1,b:2,c:3',',',':');\n 
map("a":"1","b":"2","c":"3") """)
    +case class StringToMap(text: Expression, pairDelim: Expression, 
keyValueDelim: Expression)
    +  extends TernaryExpression with ExpectsInputTypes {
    --- End diff --
    
    Here is another difference from Hive again. Ours will returns `null` if one 
of the parameter is `null`, but Hive works like the following.
    ```
    select str_to_map('a:1,b:2,c:3',null,null)  -> Hive SemanticException
    select str_to_map('a:1,b:2,c:3',null)  -> Hive SemanticException
    ```
    Could you add these two testcases, too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to