Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14071#discussion_r69837833
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
 ---
    @@ -45,35 +45,28 @@ case class CatalogFunction(
      */
     case class CatalogStorageFormat(
         locationUri: Option[String],
    -    inputFormat: Option[String],
    -    outputFormat: Option[String],
    -    serde: Option[String],
    -    compressed: Boolean,
    -    serdeProperties: Map[String, String]) {
    +    provider: Option[String],
    --- End diff --
    
    it'd be good to document in classdoc what these mean, and in what cases can 
it be None, and the behavior for hive.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to