Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14004#discussion_r69853496
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala ---
@@ -347,4 +347,24 @@ class StringFunctionsSuite extends QueryTest with
SharedSQLContext {
df2.filter("b>0").selectExpr("format_number(a, b)"),
Row("5.0000") :: Row("4.000") :: Row("4.000") :: Row("4.000") ::
Row("3.00") :: Nil)
}
+
+ test("string sentences function") {
+ val df = Seq(("Hi there! The price was $1,234.56.... But, not now.",
"en", "US"))
+ .toDF("str", "language", "country")
+
+ checkAnswer(
+ df.selectExpr("sentences(str, language, country)"),
+ Row(Seq(Seq("Hi", "there"), Seq("The", "price", "was"), Seq("But",
"not", "now"))))
+
+ // Type coercion
+ checkAnswer(
+ df.selectExpr("sentences(null)", "sentences(10)", "sentences(3.14)"),
+ Row(null, Seq(Seq("10")), Seq(Seq("3.14"))))
+
+ // Argument number exception
+ val m = intercept[AnalysisException] {
+ df.selectExpr("sentences()")
+ }.getMessage
+ assert(m.contains("Invalid number of arguments"))
--- End diff --
It is `Invalid number of arguments for function sentences`. I'll update
this, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
