Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/14065#discussion_r69918095
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -390,8 +390,9 @@ private[spark] class Client(
// Upload Spark and the application JAR to the remote file system if
necessary,
// and add them as local resources to the application master.
val fs = destDir.getFileSystem(hadoopConf)
- val nns = YarnSparkHadoopUtil.get.getNameNodesToAccess(sparkConf) +
destDir
- YarnSparkHadoopUtil.get.obtainTokensForNamenodes(nns, hadoopConf,
credentials)
+ hdfsTokenProvider(sparkConf).setNameNodesToAccess(sparkConf,
Set(destDir))
--- End diff --
it seems a bit odd to me that we are doing these extra things for hdfs
outside of the token provider.
what happens if a user needs to do something similar for some other service
they want to implement their own class to handle?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
