GitHub user rdblue opened a pull request:
https://github.com/apache/spark/pull/14093
SPARK-16420: Ensure compression streams are closed.
## What changes were proposed in this pull request?
This uses the try/finally pattern to ensure streams are closed after use.
`UnsafeShuffleWriter` wasn't closing compression streams, causing them to leak
resources until garbage collected. This was causing a problem with codecs that
use off-heap memory.
## How was this patch tested?
Current tests are sufficient. This should not change behavior.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rdblue/spark
SPARK-16420-unsafe-shuffle-writer-leak
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14093.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14093
----
commit 14ba62197e57ace8940ce71f5a6e5608b6765661
Author: Ryan Blue <[email protected]>
Date: 2016-07-07T00:50:40Z
SPARK-16420: Ensure compression streams are closed.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
