Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14080#discussion_r69988337
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java
---
@@ -64,6 +75,10 @@ public ExternalShuffleBlockHandler(TransportConf conf,
File registeredExecutorFi
public ExternalShuffleBlockHandler(
OneForOneStreamManager streamManager,
ExternalShuffleBlockResolver blockManager) {
+ this.metrics = new ShuffleMetrics();
+ this.timeDelayForOpenBlockRequest =
metrics.timeDelayForOpenBlockRequest;
+ this.timeDelayForRegisterExecutorRequest =
metrics.timeDelayForRegisterExecutorRequest;
--- End diff --
It's a little confusing how this metric is duplicated as a class member.
Would it work to just reference it through `metrics`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
