Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14065#discussion_r69992687
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/token/ServiceTokenProvider.scala
---
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.deploy.yarn.token
+
+import org.apache.hadoop.conf.Configuration
+import org.apache.hadoop.security.{Credentials, UserGroupInformation}
+import org.apache.hadoop.security.token.Token
+
+import org.apache.spark.SparkConf
+
+/**
+ * An interface to provide tokens for service, any service wants to
communicate with Spark
+ * through token way needs to implement this interface and register into
+ * [[ConfigurableTokenManager]] through configurations.
+ */
+trait ServiceTokenProvider {
+
+ /**
+ * Name of the ServiceTokenProvider, should be unique. Using this to
distinguish different
+ * service.
+ */
+ def serviceName: String
+
+ /**
+ * Used to indicate whether a token is required.
+ */
+ def isTokenRequired(conf: Configuration): Boolean = {
+ UserGroupInformation.isSecurityEnabled
+ }
+
+ /**
+ * Obtain tokens from this service, tokens will be added into
Credentials and return as array.
+ */
+ def obtainTokensFromService(
--- End diff --
If you follow Tom's suggestion and turn this into a generic
"obtainCredentials" method, then you could potentially merge it with
`getTimeFromNowToRenewal` too.
e.g. the provider is responsible for adding the tokens to the `Credentials`
object, and it returns when it should be called again to renew those tokens (or
obtain new credentials). One less method in the interface!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
