Github user petermaxlee commented on the issue:
https://github.com/apache/spark/pull/13991
I pushed a new change to this. We now have better error messages and test
coverage for those. These expressions also now require foldable paths.
I also changed the test values to make sure we are not restricting the
range of values an expression can return (e.g. for XPathInt the test case makes
sure it can return a value larger than short). However, I don't think it'd make
sense to test overflow behavior because those are mostly undefined throughout
Spark SQL.
Re: @rxin's suggestion on using RuntimeReplaceable -- I did try that, but
I'm afraid the current implementation of RuntimeReplaceable isn't meant for
stacking multiple expressions together, and time checking actually breaks if
XPathInt replaces itself with Cast(XPathDouble). I looked into fixing that, but
it seemed more complicated and it doesn't actually save much space (it actually
takes more code to use RuntimeReplaceable).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
