Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14095#discussion_r70028852
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -228,6 +228,15 @@ class Dataset[T] private[sql](
         }
       }
     
    +  private def aggregatableColumns: Seq[Expression] = {
    +    schema.fields
    +      .filter(f => f.dataType.isInstanceOf[NumericType] || 
f.dataType.isInstanceOf[StringType])
    +      .map { n =>
    +        queryExecution.analyzed.resolveQuoted(n.name, 
sparkSession.sessionState.analyzer.resolver)
    +          .get
    --- End diff --
    
    Ur, this is an direct extension of line 225 of existing `numericColumns`.
    
    
https://github.com/apache/spark/pull/14095/files#diff-7a46f10c3cedbf013cf255564d9483cdR225


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to