Github user lovexi commented on a diff in the pull request:
https://github.com/apache/spark/pull/14080#discussion_r70171938
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java
---
@@ -143,4 +180,29 @@ private void checkAuth(TransportClient client, String
appId) {
}
}
+ /**
+ * A simple class to wrap all shuffle service wrapper metrics
+ */
+ private class ShuffleMetrics implements MetricSet {
+ private final Map<String, Metric> allMetrics;
+ // Time latency for open block request in ms
+ private final Timer openBlockRequestLatencyMillis = new Timer();
+ // Time latency for executor registration latency in ms
+ private final Timer registerExecutorRequestLatencyMillis = new Timer();
+ // Block transfer rate in mbps
+ private final Meter blockTransferRateMBytes = new Meter();
+
+ private ShuffleMetrics() {
+ allMetrics = new HashMap<>();
+ allMetrics.put("openBlockRequestLatencyMillis",
openBlockRequestLatencyMillis);
+ allMetrics.put("registerExecutorRequestLatencyMillis",
registerExecutorRequestLatencyMillis);
+ allMetrics.put("blockTransferRateBytes", blockTransferRateMBytes);
--- End diff --
Since I changed it to blockTransferRateBytes, keep the same name and
refactor metric name to blockTransferRateBytes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
