Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14122#discussion_r70180443
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -327,6 +327,11 @@ class LinearRegression @Since("1.3.0")
(@Since("1.3.0") override val uid: String
throw new SparkException(msg)
}
+ if (!state.actuallyConverged) {
+ logWarning("LinearRegression training fininshed but the result is
not converged, " +
--- End diff --
LGTM though you could use string interpolation here. Maybe slightly better
as "Linear regression training fininshed but the result is not converged
because: ..."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
