Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1218#discussion_r16206844
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -217,3 +249,13 @@ private[history] class FsHistoryProvider(conf: 
SparkConf) extends ApplicationHis
       private def getMonotonicTimeMs() = System.nanoTime() / (1000 * 1000)
     
     }
    +
    +private class FsApplicationHistoryInfo(
    --- End diff --
    
    This looks a lot like a case class but it can't be one because case classes 
can't extend each other. At the very least we should add a comment explaining 
that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to