Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14136
@jiangxb1987 Thanks for working on this. I did a quick pass, and it is a
good start. I have a few issues:
- I am a bit concerned about the memory characteristics. The worst case
scenario would be that all data gets moved to a single executor. Could you
document this behavior?
- Could you add support for all numeric types?
- Could you add SQL tests as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
