Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14116#discussion_r70352851
  
    --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
    @@ -502,20 +502,21 @@ test_that("jsonRDD() on a RDD with json string", {
     })
     
     test_that("test tableNames and tables", {
    +  previous_count <- length(tableNames())
       df <- read.json(jsonPath)
       createOrReplaceTempView(df, "table1")
    -  expect_equal(length(tableNames()), 1)
    +  expect_true(length(tableNames()) == 1 + previous_count)
    --- End diff --
    
    this is one of the existing weak point in SparkR tests, we really should 
start/end each test case in a clean state such that one doesn't affect another.
    
    In this case, is there a table/view that is left behind from before?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to