Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14149#discussion_r70444156
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -2342,6 +2342,12 @@ private[spark] object Utils extends Logging {
        * Return the initial number of executors for dynamic allocation.
        */
       def getDynamicAllocationInitialExecutors(conf: SparkConf): Int = {
    +    if (conf.get(DYN_ALLOCATION_INITIAL_EXECUTORS) < 
conf.get(DYN_ALLOCATION_MIN_EXECUTORS)) {
    +      logWarning(s"${DYN_ALLOCATION_INITIAL_EXECUTORS.key} less than " +
    +        s"${DYN_ALLOCATION_MIN_EXECUTORS.key} is invalid, will use " +
    +          s"${DYN_ALLOCATION_MIN_EXECUTORS} instead.")
    --- End diff --
    
    so this doesn't cover is the user specified the executor instances < the 
minimum seems like we should also put out a warning for that also.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to