Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/1907#issuecomment-52127404
Took a more detailed pass over the protocol and the netty parts and it
looks good to me.
One thing that I am not sure (maybe @mateiz can clarify ?) -- If we have a
connect timeout right now we throw a TimeoutException that is uncaught. I am
not sure if this will lead failures being marked as FetchFailures vs. task
failures (I think the current code path ensures the former). One way to solve
the problem is adding FetchResult(-1) on exception, though I guess the current
code doesn't do that either.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
