Github user wesolowskim commented on a diff in the pull request:
https://github.com/apache/spark/pull/14137#discussion_r70638560
--- Diff:
graphx/src/main/scala/org/apache/spark/graphx/lib/StronglyConnectedComponents.scala
---
@@ -44,6 +44,11 @@ object StronglyConnectedComponents {
// graph we are going to work with in our iterations
var sccWorkGraph = graph.mapVertices { case (vid, _) => (vid, false)
}.cache()
+ // helper variables to unpersist cached graphs
+ var prevSccGraph1 = sccGraph
+ var prevSccGraph2 = sccGraph
--- End diff --
I guess I could avoid to have this two vars, but it was hard to reason
about it code with one only. One sccGraph is persisted inside do-while loop,
and the second at the end of outside while loop. With two variables it is
clearer which graph is unpersisted. For example when do-while loop is left you
have to unpersist prevSccGraph1, but not necessarily prevSccGraph2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
