Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14167#discussion_r70784310
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -399,20 +421,20 @@ private[spark] class MesosClusterScheduler(
// Sandbox points to the current directory by default with Mesos.
(cmdExecutable, ".")
}
- val primaryResource = new File(sandboxPath,
desc.jarUrl.split("/").last).toString()
val cmdOptions = generateCmdOption(desc, sandboxPath).mkString(" ")
+ val primaryResource = new File(sandboxPath,
desc.jarUrl.split("/").last).toString()
val appArguments = desc.command.arguments.mkString(" ")
- builder.setValue(s"$executable $cmdOptions $primaryResource
$appArguments")
- builder.setEnvironment(envBuilder.build())
- conf.getOption("spark.mesos.uris").map { uris =>
- setupUris(uris, builder)
- }
- desc.schedulerProperties.get("spark.mesos.uris").map { uris =>
- setupUris(uris, builder)
- }
- desc.schedulerProperties.get("spark.submit.pyFiles").map { pyFiles =>
- setupUris(pyFiles, builder)
- }
+
+ s"$executable $cmdOptions $primaryResource $appArguments"
+ }
+
+ private def buildDriverCommand(desc: MesosDriverDescription):
CommandInfo = {
+ val builder = CommandInfo.newBuilder()
+
+ builder.setValue(getDriverCommandValue(desc))
+ builder.setEnvironment(getDriverEnvironment(desc))
+ builder.addAllUris(getDriverUris(desc).asJava)
+
--- End diff --
We should be consistent i think with spaces. In other methods i see no
space between return argument and the rest of the method body ( vs
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala#L422).
The same applies for the spaces between variable declaration and statements
( vs
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala#L142)
.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
