Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1810#discussion_r16218351
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
    @@ -146,9 +146,9 @@ object SparkEnv extends Logging {
         }
     
         val securityManager = new SecurityManager(conf)
    -
    -    val (actorSystem, boundPort) = AkkaUtils.createActorSystem("spark", 
hostname, port, conf = conf,
    -      securityManager = securityManager)
    +    val actorSystemName = if (isDriver) "driverActor" else "executorActor"
    --- End diff --
    
    Hm looks like elsewhere we call this `sparkMaster` and `sparkWorker`, so 
maybe I'll keep this consistent by calling these `sparkDriver` and 
`sparkExecutor`. Also the akka URL looks weird if we include "*ActorSystem" in 
it, e.g. `akka.tcp://driverActorSystem@localhost:7077`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to