Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r70876188
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -399,7 +402,16 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef]
with Logging {
* separated) relations here, these get converted into a single plan by
condition-less inner join.
*/
override def visitFromClause(ctx: FromClauseContext): LogicalPlan =
withOrigin(ctx) {
- val from = ctx.relation.asScala.map(plan).reduceLeft(Join(_, _, Inner,
None))
+ val relationPlan = ctx.relation.asScala.map {
+ case jrc: JoinRelationContext if jrc.broadcast != null =>
+ if (jrc.broadcast.left == null) { // default
+ Hint("BROADCAST_RIGHT", Seq.empty[String], plan(jrc))
--- End diff --
I'm happy with this kind of argument. I agree with you. I prefer to
eliminate at the first line. :)
BTW, fortunately, this logic is removed now. We can proceed without
disagreement on here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
