GitHub user JoshRosen opened a pull request:

    https://github.com/apache/spark/pull/14209

    [SPARK-16555] Work around Jekyll error-handling bug which led to silent 
failures

    If a custom Jekyll template tag throws Ruby's equivalent of a "file not 
found" exception, then Jekyll will stop the doc building process but will exit 
with a successful status, causing our doc publishing jobs to silently fail.
    
    This is caused by https://github.com/jekyll/jekyll/issues/5104, a case of 
bad error-handling logic in Jekyll. This patch works around this by updating 
our `include_example.rb` plugin to catch the exception and exit rather than 
allowing it to bubble up and be ignored by Jekyll.
    
    I tested this manually with
    
    ```
    rm 
./examples/src/main/scala/org/apache/spark/examples/sql/SparkSQLExample.scala
    cd docs
    SKIP_API=1 jekyll build
    echo $?
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JoshRosen/spark fix-doc-building

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/14209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14209
    
----
commit cd89a2cbf9806e1404144370858ccdc4d7a409d6
Author: Josh Rosen <[email protected]>
Date:   2016-07-14T22:06:43Z

    Add workaround for Jekyll bug.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to