Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/13868#discussion_r70896624
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -691,7 +692,8 @@ private[sql] class SQLConf extends Serializable with
CatalystConf with Logging {
def variableSubstituteDepth: Int = getConf(VARIABLE_SUBSTITUTE_DEPTH)
def warehousePath: String = {
- getConf(WAREHOUSE_PATH).replace("${system:user.dir}",
System.getProperty("user.dir"))
+ new Path(getConf(WAREHOUSE_PATH).replace("${system:user.dir}",
+ System.getProperty("user.dir"))).toUri.toString
--- End diff --
@avulanov Is this comment addressed ? It looks to me that its a valid
concern that doing `toUri.toString` would introduce encoding that will mean we
cant use `warehousePath` as `new Path(warehousePath)` anymore ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
