Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14150#discussion_r70937028
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/feature/PCASuite.scala ---
@@ -42,7 +43,9 @@ class PCASuite extends SparkFunSuite with
MLlibTestSparkContext {
val pca_transform = pca.transform(dataRDD).collect()
val mat_multiply = mat.multiply(pc).rows.collect()
- assert(pca_transform.toSet === mat_multiply.toSet)
- assert(pca.explainedVariance === explainedVariance)
+ pca_transform.zip(mat_multiply).foreach { case (calculated: Vector,
expected: Vector) =>
--- End diff --
Not a big deal but do you really need the explicit types?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
