Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1931#issuecomment-52149487
Its a little ugly that the ContextCleaner class is being polluted with so
many parameters, and all the temporary queue length code. Wouldnt it be much
cleaner if we make a custom ReferenceQueue, which has the field length(), that
does this reflection on itself to find the queue length. All the iteration
counter, queue length checking and error message printing code can go inside
that ReferenceQueue implementation, which is cleanly separated from the main
context cleaner logic.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
