Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1932#discussion_r16223658
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
    @@ -284,16 +284,15 @@ class Word2Vec extends Serializable with Logging {
         
         val newSentences = sentences.repartition(numPartitions).cache()
         val initRandom = new XORShiftRandom(seed)
    -    var syn0Global =
    -      Array.fill[Float](vocabSize * vectorSize)((initRandom.nextFloat() - 
0.5f) / vectorSize)
    -    var syn1Global = new Array[Float](vocabSize * vectorSize)
    -
    +    var synGlobal =
    --- End diff --
    
    Making composite key in the output RDD so reduceByKey can distinguish 
whether the update is for syn0 or syn1?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to