Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1827#discussion_r16223901
  
    --- Diff: 
core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala ---
    @@ -87,7 +87,8 @@ class KryoSerializer(conf: SparkConf)
             reg.registerClasses(kryo)
           }
         } catch {
    -      case e: Exception => logError("Failed to run 
spark.kryo.registrator", e)
    +      case e: Exception => throw
    --- End diff --
    
    can you change this to
    
    ```scala
        // Allow the user to register their own classes by setting 
spark.kryo.registrator
        for (regCls <- registrator) {
          logDebug("Running user registrator: " + regCls)
          try {
            val reg = Class.forName(regCls, true, classLoader).newInstance()
              .asInstanceOf[KryoRegistrator]
            reg.registerClasses(kryo)
          } catch {
            case e: Exception => 
              throw new SparkException(s"Failed to invoke $regCls", e)
          }
        }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to