Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71094825
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -17,12 +17,21 @@
package org.apache.spark.sql.catalyst
+import java.nio.charset.StandardCharsets
+import java.nio.file.{Files, Paths}
+
import scala.util.control.NonFatal
import org.apache.spark.sql.Column
import org.apache.spark.sql.functions._
import org.apache.spark.sql.test.SQLTestUtils
+/**
+ * A testsuite for LogicalPlan-to-SQL conversion.
--- End diff --
also add something like
"Each query has a golden generated SQL file in test/resources/sqlgen. The
test suite also has built-in functionality to automatically generate these
golden files. To do so, set the saveQuery flag to true and
run the test suite. After generating the golden files, make sure to set the
flag to false."
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
