Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71100872
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -101,95 +149,125 @@ class LogicalPlanToSQLSuite extends SQLBuilderTest
with SQLTestUtils {
|# Converted SQL query string:
|$convertedSQL
|
- |# Original HiveQL query string:
- |$hiveQl
+ |# Original SQL query string:
+ |$sqlString
|
|# Resolved query plan:
|${df.queryExecution.analyzed.treeString}
""".stripMargin, cause)
}
}
+ test("checkSQL") {
--- End diff --
add some comment inline explaining what we are actually testing here - also
maybe rename the test name to "test behavior for the golden file test harness"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
