Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/14235
LGTM.
One thing is that I feel most of the times the SQL comparison assertion may
fail due to reasonable internal changes that somehow affect SQL generation in
no harmful ways, and can be fixed by simply regenerating the golden files. That
said, shall we add instructions about how to regenerate the golden files when
the the assertion fails?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
