Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14225#discussion_r71214583
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java
---
@@ -146,10 +153,8 @@ void readBatch(int total, ColumnVector column) throws
IOException {
int num = Math.min(total, leftInPage);
if (useDictionary) {
// Read and decode dictionary ids.
- ColumnVector dictionaryIds = column.reserveDictionaryIds(total);
defColumn.readIntegers(
num, dictionaryIds, column, rowId, maxDefLevel,
(VectorizedValuesReader) dataColumn);
-
if (column.hasDictionary() || (rowId == 0 &&
--- End diff --
yes, that didn't seem right to me. But it'd still be a no-op.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
