Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r71261455 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1774,6 +1775,51 @@ class Analyzer( } /** + * Substitute Hints. + * - BROADCAST/BROADCASTJOIN/MAPJOIN match the closest table with the given name parameters. + */ + object SubstituteHints extends Rule[LogicalPlan] { + def apply(plan: LogicalPlan): LogicalPlan = plan transform { + case logical: LogicalPlan => logical transformDown { + case h @ Hint(name, parameters, child) + if Seq("BROADCAST", "BROADCASTJOIN", "MAPJOIN").contains(name.toUpperCase) => + var resolvedChild = child + + for (param <- parameters) { + val names = param.split("\\.") + val tid = if (names.length > 1) { + TableIdentifier(names(1), Some(names(0))) + } else { + TableIdentifier(param, None) + } + try { + catalog.lookupRelation(tid) + + var stop = false + resolvedChild = resolvedChild.transformDown { + case r @ BroadcastHint(SubqueryAlias(t, _)) + if !stop && resolver(t, tid.identifier) => + stop = true + r + case r @ SubqueryAlias(t, _) if !stop && resolver(t, tid.identifier) => + stop = true + BroadcastHint(r) --- End diff -- Sure, If you want to remove this, I can simply this. It's a little bit legacy I tried to follow your advice as much as possible. (As I mentioned before, I decide to block in Parser layer after I found that Hive does.)
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org