Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/13382#discussion_r71266677
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockObjectWriter.scala ---
@@ -27,8 +27,8 @@ import org.apache.spark.util.Utils
/**
* A class for writing JVM objects directly to a file on disk. This class
allows data to be appended
- * to an existing block and can guarantee atomicity in the case of faults
as it allows the caller to
- * revert partial writes.
+ * to an existing block. Callers can write to the same file and commit
these writes.
+ * In case of faults, callers should atomically revert the uncommitted
partial writes.
--- End diff --
Perhaps elaborate a bit more, e.g. "For efficiency, this class retains the
underlying file channel across multiple commits to a file. The channel is kept
open until close() is called on DiskBlockObjectWriter."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
