Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14216#discussion_r71319001
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala
---
@@ -191,20 +198,20 @@ class MultivariateOnlineSummarizer extends
MultivariateStatisticalSummary with S
*/
@Since("1.1.0")
override def variance: Vector = {
- require(weightSum > 0, s"Nothing has been added to this summarizer.")
+ require(totalWeightSum > 0, s"Nothing has been added to this
summarizer.")
--- End diff --
I was going to say this might suffer from a similar problem, but summing
nonzero doubles should never result in 0, so, OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
