Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14086#discussion_r71471996
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -419,8 +422,13 @@ final class DataFrameWriter[T] private[sql](ds:
Dataset[T]) {
}
if (mode == SaveMode.Overwrite && tableExists) {
- JdbcUtils.dropTable(conn, table)
- tableExists = false
+ if (extraOptions.getOrElse("truncate", "false").toBoolean &&
+ JdbcUtils.isCascadingTruncateTable(url) == Some(false)) {
+ JdbcUtils.truncateTable(conn, table)
--- End diff --
- Drop, Create and Insert: Create and Insert could fail, but we still drop
the table.
- Truncate and Insert: Insert could fail, but we always truncate the table.
I think it is OK to raise an exception here, but check whether the
exception message is meaningful or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
