Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14240#discussion_r71634358
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/sources/PrunedScanSuite.scala ---
    @@ -114,16 +114,15 @@ class PrunedScanSuite extends DataSourceTest with 
SharedSQLContext {
       testPruning("SELECT * FROM oneToTenPruned", "a", "b")
       testPruning("SELECT a, b FROM oneToTenPruned", "a", "b")
       testPruning("SELECT b, a FROM oneToTenPruned", "b", "a")
    -  testPruning("SELECT b, b FROM oneToTenPruned", "b")
    +  testPruning("SELECT b, b FROM oneToTenPruned", "b", "b")
    +  testPruning("SELECT b as alias_b, b FROM oneToTenPruned", "b")
    --- End diff --
    
    ```SQL
    SELECT b, b FROM oneToTenPruned
    ```
    For Hive Table Scan, we exclude `ProjectExec` from the physical plan but 
[the Hive table scan returns two duplicate 
columns](https://github.com/apache/spark/blob/865ec32dd997e63aea01a871d1c7b4947f43c111/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanner.scala#L93).
 No matter whether `projectSet.size == projects.size` is added or not, the 
result is always right. 
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to