Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14296#discussion_r71647958
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1202,11 +1203,16 @@ class Analyzer(
if (resolvedOperator.resolved) {
// Try to replace all aggregate expressions in the filter by
an alias.
val aggregateExpressions = ArrayBuffer.empty[NamedExpression]
- val transformedAggregateFilter =
resolvedAggregateFilter.transform {
+ val transformedAggregateFilter =
resolvedAggregateFilter.transformDown {
case ae: AggregateExpression =>
val alias = Alias(ae, ae.toString)()
aggregateExpressions += alias
alias.toAttribute
+ case ne: NamedExpression => ne
+ case e: Expression =>
+ val alias = Alias(e, e.toString)()
+ aggregateExpressions += alias
+ alias.toAttribute
--- End diff --
looks like we are blindly pushing all expression into `Aggregate`, how
about we just push the whole filter condition?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
