Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14277#discussion_r71648748
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -204,6 +204,29 @@ case class Elt(children: Seq[Expression])
}
}
}
+
+ override protected def doGenCode(ctx: CodegenContext, ev: ExprCode):
ExprCode = {
+ val index = children.head.map(_.genCode(ctx))(0)
+ val strings = children.tail.map(_.genCode(ctx))
+ val stringValues = strings.map { eval =>
+ s"${eval.isNull} ? null : ${eval.value}"
+ }.mkString(", ")
+ val indexVal = ctx.freshName("index")
+ val stringArray = ctx.freshName("strings");
+
+ ev.copy(index.code + "\n" + strings.map(_.code).mkString("\n") + s"""
+ int $indexVal = ${index.value} - 1;
+ UTF8String[] $stringArray = {$stringValues};
--- End diff --
Let me do a simple benchmark for this. Actually I think it is no harm to
have codegen for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
