Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14275#discussion_r71685603
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/mesos/ui/DriverPage.scala ---
    @@ -50,7 +50,7 @@ private[ui] class DriverPage(parent: MesosClusterUI) 
extends WebUIPage("driver")
         val driverDescription = Iterable.apply(driverState.description)
         val submissionState = Iterable.apply(driverState.submissionState)
         val command = Iterable.apply(driverState.description.command)
    -    val schedulerProperties = 
Iterable.apply(driverState.description.schedulerProperties)
    +    val schedulerProperties = 
Iterable.apply(driverState.description.sc.getAll.toMap)
    --- End diff --
    
    One thing that concerns me besides this being a bit verbose is that it does 
not provide whose properties these are. 
    It would be ok i guess if sc properties are propagated without any 
modification to all involved components, is this the case?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to