Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14275#discussion_r71869025
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -105,16 +105,25 @@ private[mesos] object MesosSchedulerBackendUtil
extends Logging {
def addDockerInfo(
container: ContainerInfo.Builder,
image: String,
+ containerizer: String,
volumes: Option[List[Volume]] = None,
- network: Option[ContainerInfo.DockerInfo.Network] = None,
portmaps: Option[List[ContainerInfo.DockerInfo.PortMapping]] =
None): Unit = {
-
- val docker = ContainerInfo.DockerInfo.newBuilder().setImage(image)
-
- network.foreach(docker.setNetwork)
- portmaps.foreach(_.foreach(docker.addPortMappings))
- container.setType(ContainerInfo.Type.DOCKER)
- container.setDocker(docker.build())
+ val dockerContainerizer = containerizer == "docker"
+ if (dockerContainerizer) {
--- End diff --
`containerizer match { ...` is another way to write this, which might at
least let you easily throw a no-match exception if it's an unsupported value.
No big deal
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
