Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14295#discussion_r71920301 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Last.scala --- @@ -42,6 +42,17 @@ case class Last(child: Expression, ignoreNullsExpr: Expression) extends Declarat override def children: Seq[Expression] = child :: Nil + // SPARK-16648: Default `TreeNode.withNewChildren` implementation doesn't work for `Last` when --- End diff -- Well, it's probably unnecessary, since expressions are not part of the public API and won't appear in the generated ScalaDoc anyway...
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org