Github user ash211 commented on the pull request:
https://github.com/apache/spark/pull/1956#issuecomment-52262922
Ah and the order they should be shut down in is RecordReader then
FileSystem?
Thanks for catching this -- I've seen it myself and was wondering why the
job output seemed to be correct
On Aug 14, 2014 8:28 PM, "Sandy Ryza" <[email protected]> wrote:
> This occurs when an executor process shuts down while tasks are executing
> (e.g. because the driver disassociated or an OOME).
>
> Hadoop FileSystems register a shutdown hook to close themselves.
> RecordReaders get closed in a finally block after the tasks that they're
> used in.
>
> So there's a race between these two and I can't think of a good way to
> make one execute after the other. I'm a little confused as to why the
> HadoopRDD finally block is running at all. Some googling seems to indicate
> that finally blocks don't run during a System.exit(). And I would think a
> ShutdownHook would run after that happens anyway. So I can't claim to have
> 100% understanding of what's going on here. Spark isn't closing the
> FileSystem on its own.
>
> More generally, think logging a warning is overkill on a reader close
> error.
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/1956#issuecomment-52262225>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
