Github user rerngvit commented on a diff in the pull request:
https://github.com/apache/spark/pull/14309#discussion_r71986608
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -641,6 +641,10 @@ class DataFrameSuite extends QueryTest with
SharedSQLContext {
Row(key, value, key + 1)
}.toSeq)
assert(df.schema.map(_.name) === Seq("key", "valueRenamed", "newCol"))
--- End diff --
@jaceklaskowski: I agree with you that the code can be made shorter and
more elegant in the ways that you pointed out. Nonetheless, the improvements:
(1) removing () in toDF() and (2) replacing the schema map with fieldNames, are
actually applicable to other places in the file "DataFrameSuite.scala" as well.
In other words, it is not directly related to this PR. I think the proper way
to handle this is rather in another JIRA issue. Feel free to fire it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
