Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14335#discussion_r71990265
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -472,12 +473,13 @@ final class OnlineLDAOptimizer extends LDAOptimizer {
gammaPart = gammad :: gammaPart
}
Iterator((stat, gammaPart))
- }
+ }.persist(StorageLevel.MEMORY_AND_DISK)
val statsSum: BDM[Double] =
stats.map(_._1).treeAggregate(BDM.zeros[Double](k, vocabSize))(
_ += _, _ += _)
- expElogbetaBc.unpersist()
val gammat: BDM[Double] = breeze.linalg.DenseMatrix.vertcat(
stats.map(_._2).flatMap(list =>
list).collect().map(_.toDenseMatrix): _*)
+ stats.unpersist(false)
--- End diff --
I tend to agree with not blocking, though lots of code uses the default of
blocking for the RDD's removal. I don't know whether to prefer consistency or
what. I'm neutral.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
