Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14284#discussion_r71993975
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WindowExec.scala ---
@@ -625,10 +643,12 @@ private[execution] final class
OffsetWindowFunctionFrame(
if (inputIndex >= 0 && inputIndex < input.size) {
--- End diff --
This is a more general comment, which does not necessarily apply to this
line. Since we are breaking the code up into to separate code paths (with
row/without row), we might as well get rid of the joined row and the logic
needed to set this up (like: `Seq.fill(ordinal)(NoOp)`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
