Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14331#discussion_r71996213
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -365,9 +365,6 @@ private[hive] class HiveClientImpl(
},
schema = schema,
partitionColumnNames = partCols.map(_.name),
- sortColumnNames = Seq(), // TODO: populate this
- bucketColumnNames = h.getBucketCols.asScala,
- numBuckets = h.getNumBuckets,
--- End diff --
Can we explicitly set `bucketSpec` to `None` at here? Also, let's add a
comment to explain the reason that we do not populate this variable at here?
btw, I think we will not populate this info for a bucketed hive table
because we are using different hash functions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
