Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1950#discussion_r16279806
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -550,25 +579,35 @@ object DecisionTree extends Serializable with Logging
{
// Apply each filter and check sample validity. Return false when
invalid condition found.
for (filter <- parentFilters) {
--- End diff --
Please update this line to `parentFilter.foreach { filter =>` which is
faster than `for`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
