Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r72011145
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,49 @@ class Analyzer(
}
/**
+ * Substitute Hints.
+ * - BROADCAST/BROADCASTJOIN/MAPJOIN match the closest table with the
given name parameters.
+ *
+ * This rule substitutes `UnresolvedRelation`s in `Substitute` batch
before `ResolveRelations`
+ * rule is applied. Here are two reasons.
+ * - To support `MetastoreRelation` in Hive module.
+ * - To reduce the effect of `Hint` on the other rules.
+ *
+ * After this rule, it is guaranteed that there exists no unknown `Hint`
in the plan.
+ * All new `Hint`s should be transformed into concrete Hint classes
`BroadcastHint` here.
+ */
+ object SubstituteHints extends Rule[LogicalPlan] {
--- End diff --
then should we wrap the whole query plan with `Hint` instead of just the
relation?
https://github.com/apache/spark/pull/14132#discussion-diff-71820260R343
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
