Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14306#discussion_r72042273
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala
---
@@ -73,6 +73,6 @@ case class LocalRelation(output: Seq[Attribute], data:
Seq[InternalRow] = Nil)
}
}
- override lazy val statistics =
+ override def statistics(implicit parents: Option[Seq[LogicalPlan]] =
None): Statistics =
--- End diff --
Why would you add the implicit parents? Where do you need these?
Also Option[Seq[..]] is kinda an anti-pattern, since you can pass an empty
Seq around.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
